quickgraph Work Item Rss Feed

Commented Issue: GraphvizColor properties [23557]

bugmenot2 — Thu, 09 May 2013 18:30:51 GMT

the GraphvizColor class properties return the worng variable

public byte A { get { return this.a } }
public byte R { get { return this.a } }
public byte G { get { return this.a } }
public byte B { get { return this.a } }

instead of:

public byte A { get { return this.a } }
public byte R { get { return this.r } }
public byte G { get { return this.g } }
public byte B { get { return this.b } }
Comments: ** Comment from web user: bugmenot2 **

Could someone be so kind to provide me with an updated QuickGraph.Graphviz.dll file?

I tried building it myself, to no avail.

Thank you.

Commented Issue: bug in HoffmanPavleyRankedShortestPathAlgorithm [16473]

thelawnet — Sun, 24 Feb 2013 00:46:05 GMT

In HoffmanPavleyRankedShortestPathAlgorithm.cs the algorithm can get caught in the while-loop starting at line 107. If the path found contains a cycle, it is not added to the list of found pathes, but still its deviation pathes are added to the queue. So it may happen (and does in an example that I encountered), that ComputedShortestPathCount does not increase, the queue grows and grows and the loop never exits. Shouldnt you put the "// append new deviation paths" block under the condition "if (!EdgeExtensions.HasCycles<TVertex, TEdge>(path))" ?
Comments: ** Comment from web user: thelawnet **

" Shouldnt you put the "// append new deviation paths" block under the condition "if (!EdgeExtensions.HasCycles<TVertex, TEdge>(path))" ?"

If you do that it won't find all the shortest paths, e.g., where you wish to travel from A to B, which are both points connected in a loop, and the shortest path is one way round the loop, but there is a longer path going the other way.

Commented Issue: GraphvizColor properties [23557]

MattOl — Tue, 04 Dec 2012 22:15:52 GMT

the GraphvizColor class properties return the worng variable
 
public byte A { get { return this.a } } 
public byte R { get { return this.a } } 
public byte G { get { return this.a } } 
public byte B { get { return this.a } } 
 
instead of:
 
public byte A { get { return this.a } } 
public byte R { get { return this.r } } 
public byte G { get { return this.g } } 
public byte B { get { return this.b } } 
Comments: ** Comment from web user: MattOl **

I have uploaded a patch for this.

Created Issue: GraphvizColor properties [23557]

barp — Tue, 30 Oct 2012 16:44:43 GMT

Created Issue: KeyNotFoundException on adding edge in BidirectionalGraph on huge data [23415]

uhim — Wed, 26 Sep 2012 16:05:31 GMT

Is reproduced on adding huge amount of data (25000 vertices, 40000 edges) to graph.
I subscribe on VertexAdded and try adding edge in my OnVertexAdded method.
I get the attached exception.
When debugging I tried to check if graph contains both vertices I'm trying to create an edge on - yes it does.

Created Issue: CondensationAlgorithm [23392]

mikkelporse — Wed, 19 Sep 2012 09:13:22 GMT

QuickGraph.Algorithms.Condensation.CondensationGraphAlgorithm fails on Compute() for weaklyconnected components if input is a graph containing Vertices without edges

[Test]
public void TestWeaklyConnectedComponents()
{
var graph = new BidirectionalGraph<int, Edge<int>>();
graph.AddVerticesAndEdge(new Edge<int>(1, 2));
graph.AddVerticesAndEdge(new Edge<int>(2, 3));
graph.AddVerticesAndEdge(new Edge<int>(4, 5));
graph.AddVerticesAndEdge(new Edge<int>(4, 6));
graph.AddVerticesAndEdge(new Edge<int>(7, 1));
//graph.AddVertex(8); // uncomment me to reproduce error

var condensed = new QuickGraph.Algorithms.Condensation.CondensationGraphAlgorithm<int, Edge<int>, BidirectionalGraph<int, Edge<int>>>(graph);
condensed.StronglyConnected = false;
condensed.Compute(); // Throws KeyNotFoundException if edgeless vertex is added
}

Commented Issue: Don't use Comparer.Default in RootedAlgorithmBase.SetRootVertex() [22118]

isaks — Wed, 29 Aug 2012 10:33:44 GMT

In QuickGraph.Algorithms.RootedAlgorithmBase<TVertex,TGraph>.SetRootVertex(TVertex rootVertex) you do the following to check, if the same root vertex is already set:

Comparer<TVertex>.Default.Compare(this.rootVertex, rootVertex) != 0;

This is a problem, if you use a TVertex, which is not IComparable. It would be better to use EqualityComparer<TVertex>.Default, which uses the IEquatable<TVertex> interface or the standard .Equals()-method, which is present for every object.

As a consequence, at the moment no algorithm derived from RootedAlgorithmBase is able to process graphs using a TVertex, which is not IComparable.
Comments: ** Comment from web user: isaks **

I think I was hit by this as well. After upgrading my nuget dependency to the 3.6 release my code stopped working:

I got an exception in ShortestPathsDijkstra for IUndirectedGraph saying something about IComparable. I guessed that I had to implement IComparable for my TVertex and indeed that did solve the problem.

Created Issue: Bug in serialization with single-line xml [23203]

jgouveia — Tue, 21 Aug 2012 14:12:55 GMT

I found the following bug: if the description of a node/edge in in the same xml line, alternate data information is ignored. This is due to the following code

// read data
while (subReader.Read())
{
if (reader.NodeType == XmlNodeType.Element &&
reader.Name == "data" &&
reader.NamespaceURI == this.graphMLNamespace)
ReadDelegateCompiler.VertexAttributesReader(subReader, this.graphMLNamespace, vertex);
}

Since the VertexAttributesReader advances also the reader, when there is no intermediate node, the are two consecutive reads and on is lost.

The following code change in the loop corrects the situation:

// read data
subReader.Read();
while (!subReader.EOF) //changed guard
{
if (reader.NodeType == XmlNodeType.Element &&
reader.Name == "data" &&
reader.NamespaceURI == this.graphMLNamespace)
{
ReadDelegateCompiler.VertexAttributesReader(subReader, this.graphMLNamespace, vertex);
}
else
subReader.Read(); //also advance here
}

Commented Issue: ContainsEdge() with UndirectedGraph not recognizing reverse direction [21805]

michaelrbk — Mon, 25 Jun 2012 23:20:10 GMT

Hi all!

This may be a problem:

var g = new UndirectedGraph<int, UndirectedEdge<int>>();

g.AddVerticesAndEdge(new UndirectedEdge<int>(1, 2));

var c = g.ContainsEdge(2, 1); // false

The last line returns false, however since this is an undirected graph, IMHO should really return true. Am I wrong?
Comments: ** Comment from web user: michaelrbk **

I would appreciate a solution as well.

Created Issue: graphviz - DOT output/format [22749]

thk — Sun, 13 May 2012 19:17:02 GMT

First of all, this isn't a bug report, its more like a feature proposal and a big thank you.
Quickgraph was really helpful in so many places and now its time to give something back.

The graphviz output currently has a few bugs and limitations.
Within the last project i needed to fix most of them and to produce a somewhat more flexible out.
You'll find the result of these efforts attached to this issue.

So these changes include:
- Removed no longer existing graph, edge and node attributes.
- Fixed attribute spelling errors.
- Fixed edge head/tail-port output.
- Added some missing graph,edge and node attributes.
- Unified serialization.
- Added support for clusters. (needs the fix from Issue: #22746 )
- Added support for color lists/gradients.
- Added support for arrow combinations.
- Added GraphvizColors for System.Drawing.Colors.

Created Issue: EdgeListGraph - GetVertexCounts() => KeyNotFoundException [22746]

thk — Sun, 13 May 2012 15:24:35 GMT

Both properties "VertexCount" and "Vertices" rely on the "GetVertexCounts()" method.
The latter always fails with a KeyNotFoundException, since the vertices dictionary is initially empty.

private Dictionary<TVertex, int> GetVertexCounts( )
{
var vertices = new Dictionary<TVertex, int>( this.EdgeCount * 2 );
foreach ( var e in this.Edges )
{
vertices[e.Source]++;
vertices[e.Target]++;
}
return vertices;
}

so a solution would be e.g.:

foreach ( var e in this.Edges )
{
if ( !vertices.ContainsKey( e.Source ) )
vertices[e.Source] = 1;
else
vertices[e.Source]++;
if ( !vertices.ContainsKey( e.Target ) )
vertices[e.Target] = 1;
else
vertices[e.Target]++;
}

Created Issue: Ports not added edges for Record based nodes [22699]

mw81 — Fri, 04 May 2012 08:41:19 GMT

Generating dot otuput for graphviz does not add the ports to the node ids. Therefore the graphviz dot.exe is not be able to link the edges to the correct cell.

Format for record based nodes, see: http://www.graphviz.org/content/node-shapes#record

This is the output of quickgraph:
1 -> 3 [ fontname="Arial", fontsize=8, headlabel="A.1", decorate=true, label="PK-1010", taillabel="A.1", headport="P7", tailport="P40"];

This is how it should be:
1:P7 -> 3:P40 [ fontname="Arial", fontsize=8, headlabel="A.1", decorate=true, label="PK-1010", taillabel="A.1", headport="P7", tailport="P40"];

Created Issue: Invalid Dot-Output for Record-based nodes [22698]

mw81 — Fri, 04 May 2012 07:46:30 GMT

When generating graphviz dot output, the '|' delimiter between the Cells of a record is missing it the following cell contains subcells. The file can not be processed the graphviz dot.exe.

The following sample shows a record, where the delimiters after "NodeA" and "SubModule-A2" are missing
0 [shape=record, style=rounded, label="<P1> NodeA { <P2> SubModule-A1 | <P3> SubModule-A2 { <P4> SubSubModule-A2.1 } } "];

Here is the correct solution:
0 [shape=record, style=rounded, label="<P1> NodeA | { <P2> SubModule-A1 | <P3> SubModule-A2 | { <P4> SubSubModule-A2.1 } } "];

I used the following code to generate the graph and applied a bugfix in my application by using the following ApplyBugFix(string text) method.

var graph = new MyGraph();
var graphviz = new GraphvizAlgorithm<MyNode, MyEdge>(graph);

graphviz.FormatVertex += OnGraphvizFormatVertex;
graphviz.FormatEdge += OnGraphvizFormatEdge;

.... creating the graph...

string output = graphviz.Generate();
output = ApplyBugFix(output);

using (var writer = new StreamWriter(outputFile))
{
writer.Write(output);
}

private static string ApplyBugFix(string text)
{
// replace missing | in node-structures
return text.Replace("{ <", "| { <");
}

Commented Issue: FileDotEngine problem [21826]

steven_sheu — Mon, 02 Apr 2012 09:28:11 GMT

I have an old project which has QuickGraph.Graphviz version 3.6.0.0 and downloaded the latest today for another project it has QuickGraph.Graphviz version 3.6.61114.0 and it doesn't include FileDotEngine
was it intended? my legacy code doesn't work anymore? any suggestions for alternative implementation?
Comments: ** Comment from web user: steven_sheu **

I manually add the FileDotEngine class as follows and the code is found in the link:
https://quickgraph.svn.codeplex.com/svn/2.0/sources/QuickGraph.Graphviz/FileDotEngine.cs

namespace QuickGraph.Graphviz
{
public sealed class FileDotEngine : IDotEngine
{
public string Run(GraphvizImageType imageType, string dot, string outputFileName)
{
string output = outputFileName + ".dot";
File.WriteAllText(output, dot);
return output;
}
}
}

Commented Issue: FileDotEngine problem [21826]

steven_sheu — Mon, 02 Apr 2012 08:18:07 GMT

I got the same problem. Any solution ?

Created Issue: Nuget package missing QuickGraph.Glee [22436]

Peter126 — Thu, 22 Mar 2012 21:58:19 GMT

I installed QuickGraph via Nuget, on Visual Studio Professional 2010. I can now access the assemblies QuickGraph, QuickGraph.Algorithms, QuickGraph.Collections, QuickGraph.Contracts, QuickGraph.Data, QuickGraph.Graphviz, QuickGraph.Predicates, and QuickGraph.Serialization. However, when I try to import the glee extensions via "using QuickGraph.Glee", it cannot find the assembly. Did I make a mistake, or have the newer versions dropped Glee support?

Thank you for your help!

Created Issue: Strong name for QuickGraph.Data [22399]

ErikEJ — Tue, 13 Mar 2012 18:37:18 GMT

It is missing from that DLL, and I require strong named assemblies - how can I remedy? (QuickGraph.dll is strong named)

Created Issue: Strong name for QuickGraph.Data [22398]

ErikEJ — Tue, 13 Mar 2012 18:37:09 GMT

It is missing from that DLL, and I require strong named assemblies - how can I remedy? (QuickGraph.dll is strong named)

Commented Issue: SourceFirstTopologicalSortAlgorithm throws NonAcyclicGraphException [22356]

teheran — Mon, 12 Mar 2012 23:14:33 GMT

The following code makes SourceFirstTopologicalSortAlgorithm throws a NonAcyclicGraphException for no apparent reason:

BidirectionalGraph<string, Edge<string>> graph = new BidirectionalGraph<string, Edge<string>>();
graph.AddVerticesAndEdge(new Edge<string>("1", "2"));
graph.SourceFirstTopologicalSort();

The TopologicalSortAlgorithm appears to work properly.

gabriel
Comments: ** Comment from web user: teheran **

The following code throws the same exception:

var test = new AdjacencyGraph<string, Edge<string>>();
test.AddVerticesAndEdgeRange(new[]
{
new Edge<string>("A", "B"),
new Edge<string>("A", "C"),
});
test.SourceFirstTopologicalSort();

It's seems SourceFirstTopologicalSort works unpredictable.

Dmitry.

Created Issue: SourceFirstTopologicalSortAlgorithm throws NonAcyclicGraphException [22356]

gduford — Tue, 06 Mar 2012 21:38:19 GMT